vlsi commented on PR #105: URL: https://github.com/apache/xalan-java/pull/105#issuecomment-1767849230
It would be better to have separate commits for "rename files" and "modify files". Currently, "Cutover from Ant-based build to Maven-based build" commit hides a lot, and it is hard to tell if it performs only the intended changes as there are a lot of renamed and modified files at the same time. --- `+9,777 −1,199` changeset look suspicious to me. For instance, it looks like this commit resurrects `xalan/src/main/java/org/apache/xalan/xsltc/compiler/XPathParser.java` which should have been deleted long ago. The same goes for `xalan/src/main/java/org/apache/xalan/xsltc/compiler/sym.java`. It looks like `samples/src/site/xhtml/AppletXMLtoHTML/README.xhtml` duplicates `samples/src/main/java/org/apache/xalan/samples/AppletXMLtoHTML/README.html`. @jkesselm , could you please split "rename files" from "modify files" changes, exclude generated code from the PR and exclude duplicated files? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
