jkesselm commented on PR #113: URL: https://github.com/apache/xalan-java/pull/113#issuecomment-1808291701
Interesting question. Ideally all fixed should be accompanied by some form of before-and-after test. Sometimes that winds up being a human probing it and vouching for it. I'm not aware of an automated memory-leakage metric, though that info can be gotten from core dumps so there is _probably_ a way to probe it through the debugging APIs. If you happen to know of a trustworthy implementation that could be used from a regression test, I'd appreciate a pointer. If not, that might be an interesting little R&D project for someone; meanwhile human attestation may be the best available. We have a performance suite in our test set, though again that's hard to do reliably without a human in the loop. Especially in hotspot JIT compilers, which can optimize differently every run. Again, specific proposals for reliable automatable metrics that we could add to our toolkit are welcome, or we can rely on humans. By inspection, the change appears unlikely to be costly; it's just nulling one field. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
