kriegaex commented on PR #120: URL: https://github.com/apache/xalan-java/pull/120#issuecomment-1811664089
As far as I can see, the only module in which Shade makes sense is the `xalan` module anyway, and there you redundantly defined the plugin already. It also is in the `samples` and `serializer` modules, where IMO it adds no value. Can you please explain why you think you want to shade each artifact? Is it even necessary for the `xalan` module, if you build a binary assembly later anyway? Usually, Shade or Assembly are only used, if you want to build a stand-alone application that should include all of its dependencies, to be able to run it from the CLi with an easy Java command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
