kriegaex commented on PR #120: URL: https://github.com/apache/xalan-java/pull/120#issuecomment-1813715520
> Xalan currently promises to run on JRE 8. That doesn't absolutely require that we build on JDK 8, I suppose, but I want to retain the ability to do so. Then we need two variants of the Taglet classes, one using the old API and one the new one. The APIs need to be used in different ways, and the old classes are no longer available and therefore do not even compile on newer JDKs. The other way around, the new APIs are unavailable in JDK 8. I.e., duplicate taglet classes and conditional compilation using auto-activated, JDK-dependent profiles. > For now, that rules out requiring 9+. But we'll move forward someday. And users may want to build their own copies on newer versions. See above. > It's orthogonal to the Maven migration, though. That is true on the one hand, but OTOH maybe it is worth doing now. I have never used taglets at all, but it would be a nice puzzle to solve to adjust the taglet classes to the new API and to get the build running as described above. Next time I am stuck in another project and need an exercise to stretch my mind, I might look into it. I have actually begun to do so already, albeit superficially. > So I think the right thing to do is open it as a Jira Issue and get back to it. https://issues.apache.org/jira/browse/XALANJ-2709 > Fourth option: make the taglet itself introspect and pick the right set of APIs. That is not a good option, because without reflection it would not work. See above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
