jkesselm commented on PR #121: URL: https://github.com/apache/xalan-java/pull/121#issuecomment-1828186277
The comment changes are fine. My one concern about this is that you've fixed some field and method names. That could be a breaking change if customers have coded against the old names. I'd recommend looking at whether there's a way to proxy the new names with the old names, and deprecate those proxies. That gives users a development cycle's worth of warning that this change will occur. (I don't think there are any instances of "occured" in the official Xalan, JAXP, or TrAX APIs... but if it isn't `private`, there *is* a risk someone is accessing it, whether they should or not.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org For additional commands, e-mail: dev-h...@xalan.apache.org
