Thanks for the reminder, Gary.

--
   /_  Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
   /   https://www.amazon.com/dp/B09WJ3H657/

Caveat: Opinionated old geezer with overcompensated writer's block. May be 
redundant, verbose, prolix, sesquipedalian, didactic, officious, or redundant.
________________________________
From: Gary Gregory <garydgreg...@gmail.com>
Sent: Friday, December 1, 2023 4:42:17 PM
To: dev@xalan.apache.org <dev@xalan.apache.org>
Subject: Re: Can we keep Git more focused?

Note that all decisions, design or otherwise, MUST be recorded on the mailing 
list, so might as well keep the discussion here. Sometimes, discussions need to 
look at code, so GitHub makes sense, but the end result must be recorded here 
in some form.

Gary

On Fri, Dec 1, 2023, 12:12 PM Joseph Kesselman 
<kesh...@alum.mit.edu<mailto:kesh...@alum.mit.edu>> wrote:

We're getting into a bad pattern of trying to design in PR reviews. (I've been 
guilty of it too.)

May I suggest that we keep review focused on "is it an improvement" and "is 
there any reason not to commit", and move extended discussion back to the dev 
list?

One can always issue a subsequent PR if there is something that can be improved 
further. But we should be discussing most of those changes here before the next 
PR, rather than in the current PR.

Yes, nit-picking is technically (and literally) grooming behavior. But it can 
get in the way of actually doing things.



--
   /_  Joe Kesselman (he/him/his)
-/ _) My Alexa skill for New Music/New Sounds fans:
   /   https://www.amazon.com/dp/B09WJ3H657/

Caveat: Opinionated old geezer with overcompensated writer's block. May be 
redundant, verbose, prolix, sesquipedalian, didactic, officious, or redundant.

Reply via email to