[
https://issues.apache.org/jira/browse/XALANJ-2714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17792750#comment-17792750
]
Vladimir Sitnikov commented on XALANJ-2714:
-------------------------------------------
Creating a test-only module (or several of them) is fine.
However, if you mean regular xalan-commons that will be used as an explicit
dependency for xalan, then I think it is a bad idea because "commons" allows
virtually everything, and it might end up having too many classes there,
including some with CVEs and people unable to exclude a problematic jar.
See https://www.adam-bien.com/roller/abien/entry/util_packages_are_evil,
https://dave.cheney.net/2019/01/08/avoid-package-names-like-base-util-or-common
> Factor out xalan-commons?
> --------------------------
>
> Key: XALANJ-2714
> URL: https://issues.apache.org/jira/browse/XALANJ-2714
> Project: XalanJ2
> Issue Type: Improvement
> Security Level: No security risk; visible to anyone(Ordinary problems in
> Xalan projects. Anybody can view the issue.)
> Components: Samples-Examples, Serialization, TestHarness-TestCase,
> Xalan
> Reporter: Joe Kesselman
> Priority: Minor
>
> It has been proposed that there is enough replicated logic between our
> packages to justify factoring it out into a xalan-commons.jar which would be
> needed to use either Xalan or the Serializer, and the Tests. Possibly the
> samples, though we really want better samples than the ones we have.
> Personally, I'd like to start developing a list of what would go into it
> before we consider adding another moving part. If it will be of nontrivial
> size this probably makes sense, as a code cleanliness task, but I don't want
> to presume that a priori.
> I'm setting a lower initial priority because I think we have more critical
> stuff already oiled up in our backlog.
>
> This may be a large enough change to merit discussion on the developer's
> list.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@xalan.apache.org
For additional commands, e-mail: dev-h...@xalan.apache.org
