On Fri, Sep 27, 2024 at 3:42 PM Andreas Martens1 <amart...@uk.ibm.com> wrote:
> Fair, > > > > It’s annoying that github can’t ignore whitespace in its diffs. > FWIW it can somewhat: it's under the 'cog', e.g. https://github.com/apache/xalan-java/pull/189/files?diff=unified&w=1 . (still, small diffs are nice even with that feature, and applying consistent formatting in a separate commit would probably be nicer. you can even add that commit to a '.git-blame-ignore-revs'-file which some tools will pick up on - very useful unless something snuck in in that commit....) Arnout > > > Would you be against a separate PR that re-indents the files (at 2 or 4 > spaces, I’d prefer 2 but I understand if a project wants 4) in xsltc. When > looking at the files as they are I struggle to follow the code! > > > > On a related note, I’m changing the handling inside xsl:element in xsltc, > I think the changes are safe and I’m running some more tests.. Are there > sufficient unit tests in place to have confidence I haven’t broken anything > whilst stomping around in there? > > > > Cheers, > > Andreas > > > > *From: *Gary Gregory <garydgreg...@gmail.com> > *Date: *Friday, 27 September 2024 at 14:32 > *To: *dev@xalan.apache.org <dev@xalan.apache.org> > *Subject: *[EXTERNAL] Re: Reindenting a file in a PR > > My personal POV is that PRs should be as small as possible in order to > reduce the cognitive load on reviewers. Gary On Fri, Sep 27, 2024, 9: 27 > AM Andreas Martens1 <amartens@ uk. ibm. com> wrote: Hello! I’m ready to > submit a PR for XALANJ-2785. > > My personal POV is that PRs should be as small as possible in order to > reduce the cognitive load on reviewers. > > > > Gary > > > > On Fri, Sep 27, 2024, 9:27 AM Andreas Martens1 <amart...@uk.ibm.com> > wrote: > > Hello! > I’m ready to submit a PR for XALANJ-2785. > > Whilst editing some of the xsltc source files I got confused because there > was a mix of tabs and spaces in them. > > Will I be shot for re-indenting the files to be consistent? > > > > Cheers, > > Andreas > > -- > > *Andreas Martens* > > [image: signature_558150371] > > Senior Engineer > > App Connect Enterprise > > IBM > > Phone / Signal: > > +44 (0) 7824 544874 > > > > Unless otherwise stated above: > > IBM United Kingdom Limited > Registered in England and Wales with number 741598 > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU > > Unless otherwise stated above: > > IBM United Kingdom Limited > Registered in England and Wales with number 741598 > Registered office: PO Box 41, North Harbour, Portsmouth, Hants. PO6 3AU > -- Arnout Engelen ASF Security Response Apache Pekko PMC member, ASF Member NixOS Committer Independent Open Source consultant
