Hello Andreas, Thank you for your report and work. I am traveling for the next couple of days so I can't help much.
You're in the right place to ask for help. Yes, adding tests to cover fixes and changes is important, otherwise reverting behavior is possible without realizing it. Gary On Mon, Mar 31, 2025, 10:02 Andreas Martens <amart...@uk.ibm.com> wrote: > Hello all! > > > > Just been going through some of the problems our customers have hit whilst > using our XSLT functionality that’s now underpin by XSLTC rather than IBMs > XL-TXE. > > - https://github.com/apache/xalan-java/pull/189 fixes an unlimited > growth of namespaces used within XSLTC, not a problem for short-lived > programs, but we tend to run for months and years continuously processing! > - https://github.com/apache/xalan-java/pull/192 fixes what I suspect > was an accidental removal in XALANJ-2108 (in 2006!) of some code that > ensured the variable vector was closed, which was discovered shortly after > in 2008 in XALANJ-2430 (and more recently by our customer…) > - https://github.com/apache/xalan-java/pull/193 adds some > functionality to one of the shipped samples that I’ve found useful in > debugging the two above, on the vein of if I found it useful, perhaps > someone else did too! > > I ignored the one where the customer was referencing > `msxsl:node-set($var)/Namespace` from > `xmlns:msxsl="urn:schemas-microsoft-com:xslt"`, claiming that “it used to > work” > > > > I presume there are some regression tests in there somewhere, so I’m going > to see if I can find them and add my new fixes to them, so should hopefully > come with another PR for that soon (or even better, extend existing PRs if > I get there before reviews).. > > > > Anyway, how can I get these PRs reviewed and either approved or rejected? > The last two are new, but the first one is from September, so I’d like to > know what to do with it before I completely forget what I did :-) > > > > Cheers, > > Andreas > > -- > > *Andreas Martens* > > [image: signature_558150371] > > Senior Engineer > > App Connect Enterprise > > IBM > > > Unless otherwise stated above: > > IBM United Kingdom Limited > Registered in England and Wales with number 741598 > Registered office: Building C, IBM Hursley Office, Hursley Park Road, > Winchester, Hampshire SO21 2JN >
