Yqwed commented on PR #194: URL: https://github.com/apache/xalan-java/pull/194#issuecomment-4068998397
> On the other hand, if we are using an object only as a semaphore anchor, we honestly don't care what its type is. Exactly. There is absolutely no reason to prefer `new Integer(1)` or `new Boolean(true)` over `new Object()` if it is used for synchronization only. > I am currently inclined to classify it as "at worst, harmless." I'd disagree about harmless - as it is xalan can't be used in early access valhalla builds. Also OpenJDK team plans to make it a preview feature in JDK 27 (to be released this autumn) and xalan users will need to patch this library. This change has zero risks and only helps Java ecosystem as a whole. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
