ElementReader can throw NPE
---------------------------

                 Key: XFIRE-835
                 URL: http://jira.codehaus.org/browse/XFIRE-835
             Project: XFire
          Issue Type: Bug
    Affects Versions: 1.2.4, 1.2.3
         Environment: Windows XP, Tomcat
            Reporter: Jabe Bloom
         Assigned To: Dan Diephouse
            Priority: Critical


 public String getValue()
    {
        if (value == null) 
        {
            try
            {
                value = root.getElementText();

                while (checkHasMoreChildReaders()) {}
            }
            catch (XMLStreamException e)
            {
                throw new XFireRuntimeException("Could not read XML stream.", 
e);
            }
        }
        return value.trim();
    }

The return value.trim() here assumes that value != null.

Please check for null before the trim()?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply via email to