Ubuntu 20.04.6 LTS, Oracle JDK 11.0.8
* Checked signatures and checksums OK
* Checked "apache" and "incubating" in the filename OK
* Checked "RC" not present in the filename and source archives OK
* Checked diff between git repo (commit
26b77995f3dddf1116c339ab39a7e0539c4fa045) and artifacts OK [1]
(Certain directories are not included but this seems expected)
* Went over release note OK (Minor suggestions/comments at the end)
* Checked README.md for build instructions and incubating mentions OK
* Checked NOTICE, LICENSE, and DISCLAIMER-WIP OK
* All source files have ASF headers OK [2]
* No unexpected binary files OK [3]
* Checked structure for maven staging repo (not RC in URLs etc.) [4]
* Checked NOTICE, LICENSE in xtable-core-0.1.0-incubating.jar from nexus OK
* Checked signature, and checksum for
xtable-core-0.1.0-incubating.jar from nexus OK
* Built from git tag and run tests [5] OK
* Built from source artifacts and run tests [5] OK
The release notes have some duplication in each entry since there is a
copy of the title in plain text and URL, which makes things
unnecessarily verbose. Moreover, it would be useful to group entries
into some broad categories (e.g., New Features, Breaking Changes, Bugs
& Small improvements, Dependency Upgrades, Documentation, Testing) to
improve readability and highlight potentially significant changes.
Lastly, it would be nice to highlight somewhere the supported JDKs and
potentially other important requirements/dependencies for the project.
+1 (binding)
Best,
Stamatis
[1] diff -qr apache-xtable-0.1.0-incubating incubator-xtable
[2] grep -RiL "Licensed to the Apache Software Foundation"
[3] find . -type f -exec file {} \; | grep -v text
[4] https://repository.apache.org/content/repositories/orgapachextable-1004/
[5] mvn clean package
On Sun, Aug 18, 2024 at 8:14 PM Tim Brown <[email protected]> wrote:
>
> +1 (binding)
>
> - Ran tests to validate Hudi writer extensions and conversions work from
> Iceberg, Delta, and Hudi with the xtable-core jar
> - Validated the signature and contents of the upload source code tar
>
> -Tim Brown
>
> On Fri, Aug 16, 2024 at 6:18 AM Vinish Reddy <[email protected]> wrote:
>
> > Hi everyone,
> >
> > Please review and vote on the release candidate #4 for the version 0.1.0,
> > as follows:
> >
> > [ ] +1, Approve the release
> >
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> >
> > *GH release notes [1],
> >
> > * the official Apache source release and binary convenience releases to be
> > deployed to dist.apache.org [2], which are signed with the key with
> > fingerprint 5EFD1E91 [3],
> >
> > * all artifacts to be deployed to the Maven Central Repository [4],
> >
> > * source code tag "release-0.1.0-incubating-rc4" [5],
> >
> > Thanks,
> > Vinish
> >
> > [1]
> >
> > https://github.com/apache/incubator-xtable/issues/486#issuecomment-2293298003
> >
> > [2]
> >
> > https://dist.apache.org/repos/dist/dev/incubator/xtable/0.1.0-incubating-rc4/
> >
> > [2] [checksum]
> >
> > https://dist.apache.org/repos/dist/dev/incubator/xtable/0.1.0-incubating-rc4/apache-xtable-0.1.0-incubating.src.tgz.sha512
> > [2] [SVN Revision]
> > URL: https://dist.apache.org/repos/dist/dev/incubator/xtable
> > Repository UUID: 0d268c88-bc11-4956-87df-91683dc98e59
> > Revision: 70917
> > Last Changed Author: vinish
> > Last Changed Rev: 70907
> > Last Changed Date: 2024-08-16 15:09:45 +0530 (Fri, 16 Aug 2024)
> >
> > [3] https://dist.apache.org/repos/dist/release/incubator/xtable/KEYS
> >
> > [4]
> > https://repository.apache.org/content/repositories/orgapachextable-1004/
> >
> > [5] [tag]
> >
> > https://github.com/apache/incubator-xtable/releases/tag/release-0.1.0-incubating-rc4
> >
> > [5] [SHA]
> >
> > https://github.com/apache/incubator-xtable/commit/26b77995f3dddf1116c339ab39a7e0539c4fa045
> >
