Thanks, Stamatis, for the feedback. I've pushed the PRs to address the
reported issues.

On Fri, Apr 11, 2025 at 2:28 AM Stamatis Zampetakis <zabe...@gmail.com>
wrote:

> Ubuntu 22.04.5 LTS, jdk-11.0.8
>
>  [OK] Checked signatures and checksums
>  [OK] Release artifacts contain "apache" and "incubating" in the name
>  [OK] Diff between git repo and release artifacts matches
>  [OK] DISCLAIMER-WIP, LICENSE are present and correct
>  [KO] Checked NOTICE file content and distribution years (see [1])
>  [OK] Location of the KEYS file is correct
>  [OK] README contains build instructions
>  [OK] No unexpected binary files (find . -type f -exec file {} \; |
> grep -v text)
>  [OK] All source files have ASF headers (grep -RiL "Licensed to the
> Apache Software Foundation")
>  [OK] Built from source artifacts and run tests (mvn clean install)
>  [OK] Version identifier is in the expected format (0.3.0-incubating)
>  [KO] Downloaded and checked the following jars from the maven staging
> repo for LICENSE, NOTICE, DISCLAIMER, and contents (see [1, 2]:
> * xtable-api-0.3.0-incubating.jar
> * xtable-aws-0.3.0-incubating.jar
> * xtable-core_2.12-0.3.0-incubating.jar
> * xtable-hive-metastore-0.3.0-incubating.jar
> * xtable-hudi-support-extensions_2.12-0.3.0-incubating.jar
> * xtable-hudi-support-utils-0.3.0-incubating.jar
>
> Both [1, 2] are rather minor but they seem easy to fix so it's better
> to address them now to have a clean and proper LICENSE/NOTICE in the
> release.
>
> -1 (binding)
>
> Best,
> Stamatis
>
> [1] https://github.com/apache/incubator-xtable/issues/692
> [2] https://github.com/apache/incubator-xtable/issues/693
>
>
> On Wed, Apr 9, 2025 at 8:45 AM Vinish Reddy <vin...@apache.org> wrote:
> >
> > Hi everyone,
> >
> > Please review and vote on the release candidate #1 for the version 0.3.0,
> > as follows:
> >
> > [ ] +1, Approve the release
> >
> > [ ] -1, Do not approve the release (please provide specific comments)
> >
> > The complete staging area is available for your review, which includes:
> >
> > *GH release notes [1],
> >
> > * the official Apache source release and binary convenience releases to
> be
> > deployed to dist.apache.org [2], which are signed with the key with
> > fingerprint 5EFD1E91 [3],
> >
> > * all artifacts to be deployed to the Maven Central Repository [4],
> >
> > * source code tag "release-0.3.0-incubating-rc1" [5],
> >
> > Thanks,
> > Vinish
> >
> > [1]
> >
> https://github.com/apache/incubator-xtable/issues/678#issuecomment-2782345193
> >
> >
> > [2]
> >
> https://dist.apache.org/repos/dist/dev/incubator/xtable/0.3.0-incubating-rc1/
> >
> > [2] [checksum]
> >
> https://dist.apache.org/repos/dist/dev/incubator/xtable/0.3.0-incubating-rc1/apache-xtable-0.3.0-incubating.src.tgz.sha512
> >
> > [3] https://downloads.apache.org/incubator/xtable/KEYS
> >
> > [4]
> https://repository.apache.org/content/repositories/orgapachextable-1010/
> >
> > [5] [tag]
> >
> https://github.com/apache/incubator-xtable/releases/tag/0.3.0-incubating-rc1
> >
> > [5] [SHA]
> >
> https://github.com/apache/incubator-xtable/commit/44e4423c9a5dfee350514bdee129d74472c07007
>

Reply via email to