Hi Tony,

I don't know if this really represents best practice, but I can speak to
what the Hadoop project does in practice.  We have maven-checkstyle-plugin
defined in the build section of the root pom.xml file for our multi-module
project.  Our rules are externalized into an XML file at
hadoop-build-tools/src/main/resources/checkstyle/checkstyle.xml.  A small
handful of our sub-modules have exception rules that don't quite fit the
standard defined for the whole project.  For those modules, they
separately redeclare maven-checkstyle-plugin in the module's pom.xml and
point to a checkstyle.xml specific to that module.  An example is
hadoop-tools/hadoop-azure.  We actually want to get away from having any
exceptions though.  I think there is an open JIRA tracking migration of
the hadoop-azure module to use the same rules as all other modules.

I hope this helps.  Let us know if you need anything else.

--Chris Nauroth




On 10/20/15, 3:53 PM, "Tony Kurc" <[email protected]> wrote:

>I'm struggling a bit to get checkstyle working locally on apache nifi. The
>checkstyle rules are in the pom, which I think the checkstyle:checkstyle
>goal doesn't "support", but checkstyle:check does. Are there some good
>practices documented for where to put a checkstyle config in the source
>tree and what to put in your pom for test-patch to be happy?
>
>Tony

Reply via email to