Justin, thank you for your review. I really appreciate the effort you've put into thorough license reviews on multiple ASF projects. Yes, please do file a JIRA.
--Chris Nauroth On 5/18/16, 1:48 PM, "Justin Mclean" <[email protected]> wrote: >Hi, > >+1 (non-binding) Be nice to fix the couple very minor issues for the next >release. Want me to raise a JIRA? > >I checked: >- signatures and hashes good >- LICENSE OK, but the short form of licenses are generally preferred >- LICENSE missing MIT normalize.css [1] >- NOTICE OK, but included a few extra items that are not required. >Normally no need to list permissive licensed software's copyright in >NOTICE [2] >- no unexpected binaries in source >- all source files have Apache headers >- can compile from source > >Also checked the convienance binary the LICENSE and NOTICE are correct >for what is bundled (as the site is not included). > >Thanks, >Justin > >1. contained inside ./asf-site-src/source/assets/css/bootstrap.css >2. http://www.apache.org/dev/licensing-howto.html#permissive-deps
