| Hi devs,
I have not seen an users list for yetus, so I write here.
At Apache Hive we are thinking of implementing precommit validation to help the reviews and ensure better quality. I have trying to implement Yetus for Hive - see the attached personality.
It went fairly straightforward most of the time, but faced some problems which I am not sure how best to solve: - Javac plugin: When I create a personality with only maven, and javac plugin enabled, then the maven install is run for pre, and post patch, but the patch generated java compile warnings are not highlighted. Am I wrong when expecting the javac plugin to calculate the results using the patch-mvninstall-<module>.txt and branch-mvninstall-<module>.txt files? Where did I make the mistake in the configuration, why the result files are not compared?
- Test4test plugin: We have different filename patterns for tests, so to use Yetus we have to either add a new plugin or has to update the existing plugin to have the pattern as a configurable parameter. I am willing to create a patch for it if the Yetus community thinks making test4test plugin configurable is the way to go.
- Findbugs plugin: Findbugs plugin expects the project structure to be the standard maven one (/src/main/java, /src/test/java). In Hive some of the modules have a different file layout. Like above either a new plugin is needed, or a parameter should be introduced to enable changes in checking.
I am attaching the hive-personality.sh, and the output of the test run with only maven and javac enabled. If anyone can help me, or point me to the right direction, I would be very happy.
Thanks, Peter |
hive-personality.sh
Description: Binary data
test-patch.out
Description: Binary data
