checking the relevant files in the repo shows that they have the correct line endings.
the gitattributes wouldn't apply to the output of git diff or format-patch itself. lemme see if changing the line endings of the patch helps. On Thu, Jul 6, 2017 at 7:41 PM, Allen Wittenauer <[email protected]> wrote: > > > On Jul 6, 2017, at 4:35 PM, Allen Wittenauer <[email protected]> > wrote: > > > > > >> On Jul 6, 2017, at 3:42 PM, Sean Busbey <[email protected]> wrote: > >> > >> The patches are all generated on windows, using the git that comes from > the > >> github desktop application. I'm at a loss; the patches all look fine > when I > >> open them in an editor. > > > > > > "HBASE-18327.1.patch" [converted][dos] > > > > It's gotta be a character conversion problem. > > I don't think the desktop app is honoring .gitattributes ... > > ---snip-- > # Declare files that will always have LF > *.sh text eol=lf > --snip-- > > ... which is likely confusing git commands that do. > >
