Hello folks!
I'd like to have a discussion around PreCommit-Admin. Three background points that are important: 1) As hopefully everyone is aware, many jobs on the ASF Jenkins instance are using the 'hadoopqa' account to connect to JIRA. To undo that, we need better docs for projects to follow to set up their own JIRA accounts, how to configure test-patch, etc. What many of you might not know is that precommit-admin uses a token to (poorly) authenticate to the precommit-project-build jobs. That token is also set to something Hadoop specific. Changing one without changing the other will lead to confusion. Changing this token to be more generic will mean breaking compatibility with all of the existing jobs, so either a coordinated/timed event or setting up another precommit-admin job will be necessary. 2) I feel it is vital that Apache Yetus includes the precommit-admin functionality as part of the distribution. As a result, YETUS-288 was filed eons ago to copy precommit-admin from an abandoned Hadoop SVN repo into Yetus. With Brock Noland's help, that issue got closed. The version committed is the exact copy running on the ASF build servers today. It has not been made 'less ASFy' yet, but that pretty much has to happen just as it did for test-patch. (See YETUS-594 where I've started that work). To 'fly our own airplanes,' (to quote Scott McNealy) Yetus will almost certainly want to use our version of precommit-admin to trigger Yetus patch tests. 3) After our precommit-admin job is established, documentation exists, etc., there is a very high likelihood that our documentation will become the place for the general ASF community when they go to set up their new projects or convert existing ones to support a precommit patch testing hook. From the ASF-wide perspective, this may mean that others will try to set up custom precommit-admin jobs. To me, that seems a bit wasteful. In my head there look to be some decision points for the project: * Do we as a project want to open up our precommit-admin job to others? A yes decision will almost certainly mean some relatively light support for those projects, minimally in the form of editing a JIRA filter. [For the current job, I believe the JIRA filter is technically owned by Hadoop, but INFRA makes changes to it regularly.] * If so, do we want to own _the_ precommit-admin? In other words, coordinate moving from the old, unmaintained one to the Yetus version and then working towards killing off the old job? This process would minimally entail working out the details around the Jenkins token. Thoughts? TIA
