Re: expectations for java_home in docker mode

[Allen Wittenauer]

> On Sep 14, 2018, at 2:34 PM, Sean Busbey <bus...@apache.org> wrote:
> ENV JAVA_HOME=/usr/lib/jvm/zulu-7-amd64

        I’m pretty sure this gets overridden because docker.sh does this:

  DOCKER_EXTRAARGS+=("--env=JAVA_HOME=${JAVA_HOME}”)

        Given how many features have been added to Docker since the docker 
support was added (build args in particular) this whole thing needs a major 
rewrite.  But until then, a quick fix would be to pass this in as a different 
var and then make launch-test-patch use that if JAVA_HOME isn’t set. i.e.:


—snip---
cd "${BASEDIR}" || exit 1

JAVA_HOME=${JAVA_HOME:-${PRE_DOCKER_JAVA_HOME}}

if [[ -n ${JAVA_HOME}

—snip—

or whatever