apache-yetus commented on a change in pull request #44: YETUS-800. Change
github output to be review instead of comment
URL: https://github.com/apache/yetus/pull/44#discussion_r259591344
##########
File path: precommit/src/main/shell/test-patch.d/github.sh
##########
@@ -492,17 +470,28 @@ function github_linecomments
function github_write_comment
{
declare -r commentfile=${1}
+ declare status=${2}
declare retval=0
- declare restfile="${PATCH_DIR}/ghcomment.$$"
+ declare restfile="${PATCH_DIR}/ghcomment.txt"
declare githubauth
+ status=${status:-'COMMENT'}
+
+ fake='error'
Review comment:
shellcheck:3: warning: fake appears unused. Verify it or export it. [SC2034]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
