Additionally, what I did find out, when I started '
~/dev/asf/yetus/precommit/src/main/shell/test-patch.sh --plugins=all
--build-tool=gradle --patch-dir=~/dev/test/yetus
--basedir=~/dev/asf/ofbiz/ofbiz-framework
--docker https://github.com/apache/ofbiz-framework/pull/12' in my
~/dev/test folder, was:
1. in ~/dev/test a subfolder tree was created (~/dev/test/yetus)
containing following files:
1. githubub-pull.json;
2. input.diff
3. input.patch
This indicates to me that for --patch-dir and --basedir parameters their
values are treated as literally, instead of relatively (~ indicating the
user's home folder).
Met vriendelijke groet,
Pierre Smits
*Proud* *contributor* (but without privileges)* of* Apache OFBiz
<https://ofbiz.apache.org/>, since 2008
*Apache Trafodion <https://trafodion.apache.org>, Vice President*
*Apache Directory <https://directory.apache.org>, PMC Member*
Apache Incubator <https://incubator.apache.org>, committer
Apache Steve <https://steve.apache.org>, committer
On Sat, Feb 15, 2020 at 12:59 PM Pierre Smits <[email protected]>
wrote:
> Hi all,
> As per suggestion from Sean via a private conversation on Slack I am
> reaching ou to the community with an error I am experiencing as I am
> getting my feet wet while working with Yetus.
>
> Let me state some facts first:
>
> - using a MacBook
> - the Yetus code is from a cloned fork from Github, placed in
> ~/dev/asf/yetus
> - the project to work with is OFBiz with code from a cloned fork from
> Github (apache/ofbiz-framework), placed in ~/dev/asf/ofbiz/ofbiz-framework
> (the --basedir parameter)
> - the test environment is set to ~/dev/test/yetus ( the --patchdir
> parameter)
> - the patch to work with is a pull request in the OFBiz repo on
> Github: https://github.com/apache/ofbiz-framework/pull/12
>
> In a first trial run, in the basedir I executed
> '~/dev/asf/yetus/precommit/src/main/shell/test-patch.sh
> ~/Downloads/OFBIZ-11236_shipmentNotesV3.patch' and it executed perfectly.
>
> In a second trial run I am extending on that, but doing it outside of the
> basedir, to run it against a pull request instead of a local patch file. So
> I have added/changed:
>
> - the patch dir is set to ~dev/test/yetus (--patch-dir parameter)
> - the source to work with is a pull request in the OFBiz repo on Github:
> https://github.com/apache/ofbiz-framework/pull/12
>
> All the above is giving me following command to execute:
>
> ~/dev/asf/yetus/precommit/src/main/shell/test-patch.sh --plugins=all
> --build-tool=gradle --patch-dir=~/dev/test/yetus
> --basedir=~/dev/asf/ofbiz/ofbiz-framework --docker
> https://github.com/apache/ofbiz-framework/pull/12
>
>
> But this didn't execute so well, delivering following result:
>
> WARNING: Found both spotbugs and findbugs. Disabling findbugs.
>
> Modes: Docker
>
> Processing: https://github.com/apache/ofbiz-framework/pull/12
>
> GITHUB PR #12 is being downloaded from
>
> https://api.github.com/repos/apache/ofbiz-framework/pulls/12
>
> JSON data at Sat Feb 15 12:55:58 CET 2020
>
> Patch data at Sat Feb 15 12:55:59 CET 2020
>
> Diff data at Sat Feb 15 12:56:00 CET 2020
>
>
>
>
> ============================================================================
>
>
> ============================================================================
>
> Confirming git environment
>
>
> ============================================================================
>
>
> ============================================================================
>
>
>
> ERROR: is not a git repo.
>
>
>
>
> ============================================================================
>
>
> ============================================================================
>
> Finished build.
>
>
> ============================================================================
>
>
> ============================================================================
>
>
> I am suspecting that Yetus is complaining about the basedir
> (~/dev/asf/ofbiz/ofbiz-framework), but that is where my local git clone is.
>
> So, it seems I am doing something wrong. But what...
>
> Could you help me with some pointers?
>
> Met vriendelijke groet,
>
> Pierre Smits
> *Proud* *contributor* (but without privileges)* of* Apache OFBiz
> <https://ofbiz.apache.org/>, since 2008
>
> *Apache Trafodion <https://trafodion.apache.org>, Vice President*
> *Apache Directory <https://directory.apache.org>, PMC Member*
> Apache Incubator <https://incubator.apache.org>, committer
> Apache Steve <https://steve.apache.org>, committer
>
