wilfred-s commented on a change in pull request #74: Identify spark pod with
label spark-app-selector
URL:
https://github.com/apache/incubator-yunikorn-k8shim/pull/74#discussion_r375704150
##########
File path: pkg/dispatcher/dispatcher_test.go
##########
@@ -17,13 +17,15 @@ limitations under the License.
package dispatcher
import (
+ "fmt"
"runtime"
"strings"
"sync"
"sync/atomic"
"testing"
"time"
+ "github.com/apache/incubator-yunikorn-k8shim/pkg/common/utils"
Review comment:
all yunikorn imports should be grouped together. I filed new issues to fix
the linter setting but this should be with the events import (k8shim #75)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
