TaoYang526 commented on issue #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#issuecomment-597438656 @wilfred-s @yangwwei I thought we can add a new API in api.SchedulerAPI and its implementation in RMProxy: ``` // Request scheduler to validate configuration ValidateConfiguration(content string) error ``` We also need to get an instance of api.SchedulerAPI in admission-controller, I'm not sure is it acceptable to add an method in entrypoint.go like this: ``` func NewSchedulerAPI() api.SchedulerAPI { return rmproxy.NewRMProxy() } ``` In this way we still need to dependent the entrypoint package. Is there a better solution? Hope to hear your thoughts. Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
