TaoYang526 commented on issue #96: [YUNIKORN-1] Support app/task priority aware scheduling URL: https://github.com/apache/incubator-yunikorn-core/pull/96#issuecomment-598554445 @yangwwei @wilfred-s To confirm that the performance won't regress unexpectedly, I have added benchmark tests for apps sorting and pending requests iteration in latest PR. For apps sorting, it tests the performance of sorting pending apps with different policies, test results in my local environment like this (unit of consuming-time is µs): | | 10 apps | 100 apps | 1000 apps -- | -- | -- | -- | -- Before | Fair | 8.9 | 118.9 | 1129.0 | Fifo | 3.9 | 44.2 | 657.8 After | Fair | 8.6 | 125.2 | 1203.0 | Fifo | 4.7 | 81.2 | 1483.0 There is little change for Fair policy, and there's not too much change for Fifo policy, which is expected since now Fifo has more things to be considered. For pending requests iteration, it tests get and iterate 10,000 sorted pending requests with different number of priorities, expect the performance is only related to the number of pending requests, won't be affected by other factors such as the number of priorities and pending percentage, and should have better performance than before, test results in my local environment like this (unit of consuming-time is µs): | 1 priority | 2 priorities | 5 priorities | 10 priorities -- | -- | -- | -- | -- Before | 883.4 | 1642.5 | 2774.3 | 3246.9 After | 288.7 | 279.9 | 286.3 | 292.3 According to the results, it will improve a lot than before, at least 3 times enhancement and more priorities leads to more enhancement. Moreover, only priority is considered for sorting before, if it supports sorting by createTime as in this PR, the consuming-time will be much more(about 6ms for 10,000 requests).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
