yangwwei commented on issue #81: [YUNIKORN-28] Support validating yunikorn-configs before admitting it URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/81#issuecomment-598997292 Hi @TaoYang526 > I think we can only configure the name of service in configs.properties and get the http port of yunikorn service automatically in admission_util.sh via... Sounds good. > My doubt is that the namespace in admission-controller seems not related to the helm charts, are we expecting they may be different? Right now when we do helm chart install, we pass in namespace as a CLI parameter and give value "yunikorn". We should always make scheduler and admission-controller running in same namespace. So the changes needed here is to adhere the namespace value passed in from helm, and populate that into the deployment template.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
