Wilfred Spiegelenburg created YUNIKORN-51: ---------------------------------------------
Summary: cast failures are not handled correctly Key: YUNIKORN-51 URL: https://issues.apache.org/jira/browse/YUNIKORN-51 Project: Apache YuniKorn Issue Type: Bug Components: core - scheduler Reporter: Wilfred Spiegelenburg Attachments: cast_panic.go While reviewing the code for YUNIKORN-47 I noticed that we are not correctly handling cast errors which could cause panics. In all cases we use the proper cast like this: {code:java} obj, ok := i.(*T) {code} We check the value of ok but do not handle the fact correctly that we can get a nil back which could cause a panic later when we us it. examples: {{scheduler.processNodeEvent()}} test code attached to show the issue. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org