yangwwei commented on a change in pull request #109: [YUNIKORN-14] Add rest API 
to retrieve app/container history info
URL: 
https://github.com/apache/incubator-yunikorn-core/pull/109#discussion_r398270209
 
 

 ##########
 File path: pkg/webservice/handlers.go
 ##########
 @@ -235,3 +236,57 @@ func getNodeJSON(nodeInfo *cache.NodeInfo) 
*dao.NodeDAOInfo {
                Schedulable: nodeInfo.IsSchedulable(),
        }
 }
+
+func GetApplicationHistory(w http.ResponseWriter, r *http.Request) {
+       writeHeaders(w)
+
+       var result []*dao.ApplicationHistoryDAOInfo
+       lists := gClusterInfo.ListPartitions()
+       for _, k := range lists {
 
 Review comment:
   right now it reports back per partition
   I don't think front-end expect this. we should aggregate this to the cluster 
level. Can we change the `HistoricPartitionInfo` to `HistoricClusterInfo`? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org

Reply via email to