+0
I would recommend updating to DISCLAIMER-WIP for your first release 
(Seehttps://incubator.apache.org/guides/releasemanagement.html#choice_of_disclaimers
https://incubator.apache.org/policy/incubation.html#disclaimers). This should 
enable you to release quickly after this only one change. See my note below for 
items for future releases.

- incubating in name
- signature and hash fine
- DISCLAIMER is ok - as above
- LICENSE and NOTICE are fine
- Ok with binary files - see note below
- See note below on ASF headers
- didn't compile from source

1. SHOULD: instead of a personal directory, release SHOULD be staged on 
https://dist.apache.org/repos/dist/dev/incubator/yunikorn.  
https://incubator.apache.org/guides/releasemanagement.html#podling_constraints
this include the signing KEYS file that should be kept as a project KEYS file 
instead of a personal one/location
2. it is a bit strange that you have 5 LICENSE files, you can exclude the one 
in subdirectories when you build the source tarball?
3. might want to check the license for the image files: png, jpg - where are 
they from?
4. SHOULD: a large number of files should also have ASF headers, eg. .mod, 
.yaml, .md, .go
5. nice to have: more details on go setup for dev environment (maybe just a 
quick link), go setup info without GoLand IDE. It could be helpful to know more 
on how to build (is this the build step? 
https://github.com/apache/incubator-yunikorn-core/blob/master/docs/developer-guide.md#core-component-build)
6. SHOULD: put Apache Incubator logo on the 
websitehttps://incubator.apache.org/guides/press-kit.html  
http://yunikorn.apache.org/


________________________________
From: Weiwei Yang <[email protected]>
Sent: Friday, April 24, 2020 3:24:05 PM
To: [email protected] <[email protected]>
Subject: Re: [VOTE] Release Apache YuniKorn (incubating) 0.8.0-rc3

Just a correction: The voting ends on *Sunday Monday** Apr 26, 2020, 20:00
PST.*

Weiwei


On Fri, Apr 24, 2020 at 6:29 AM Sunil Govindan <[email protected]> wrote:

> +1 (binding)
>
> - checksum & signature is fine.
> - Basic build is fine
> - ran sample spark job, all looks good.
>
> Thanks
> Sunil
>
> On Fri, Apr 24, 2020 at 6:55 AM Weiwei Yang <[email protected]> wrote:
>
> > Hi all
> >
> > I'd like to call a vote for Apache YuniKorn (incubating) 0.8.0-rc3.
> (Note,
> > the only diff between RC3 and RC2 is the "-rc2" suffix has been removed
> > from the tarball/folder name)
> >
> > All release artifacts, including source code package, signatures, and
> > checksum, etc, can be found at:
> > http://people.apache.org/~wwei/apache-yunikorn-incubating-0.8.0-rc3/
> >
> > this release has been signed with PGP
> > key 8D076B6491A66D7B94E94519F57176CE11856D1F, corresponding to
> > [email protected]. You can find the KEYS file here:
> > http://people.apache.org/~wwei/KEYS.
> >
> > The release has been tagged with "*v0.8.0*" in all our git repos.
> > The JIRA issues have been resolved for this release can be found:
> > https://issues.apache.org/jira/projects/YUNIKORN/versions/12347742.
> >
> > Please review and vote. The vote will be open for at least 72 hours (that
> > ends on *Monday, Apr 26, 2020, 20:00 PST*).
> >
> > [ ] +1 approve
> > [ ] +0 no opinion
> > [ ] -1 disapprove (and the reason why)
> >
>

Reply via email to