Hi Wilfred I checked the following things on the RC2: - Verified the signature - checked sha512 - Checked LICENSE, README, CHANGELOG - built the images - run the unit tests using make test command - installed YuniKorn with helm - run some examples, scaled them up and down, edited the configmap - clicked around the UI
I found small issues during the testing: 1. There is a lot of CRD related code in the shim repository(changes introduced by YUNIKORN-170 <https://issues.apache.org/jira/browse/YUNIKORN-170>): - pkg/apis/yunikorn.apache.org/v1alpha1 - the makefile contains the code generating command 2. when running the unit tests after running the web tests, the command will not exit after finishing. As I remember the decision was to not include CRD changes in the release, not? Because of the CRD issue I would give -1 (non-binding) Regards, Kinga On Sat, Aug 15, 2020 at 7:53 AM Ayub Pathan <[email protected]> wrote: > Sunil, > > >>However I couldn't see UI pods. > Web UI container runs as part of the scheduler pod. > > Thanks > Ayub Khan > > On Fri, Aug 14, 2020 at 10:13 PM Sunil Govindan <[email protected]> wrote: > > > Thanks Wilfred for putting this release together > > > > +1 binding > > > > - verified the signature and it looks good > > - changelog, readme, license etc looks good > > - locally built the images and binaries. This was done based on README.md > > instructions. > > - MINOR issue: yunikorn UI docker build reports few warnings which can be > > fixed separately. This doesn't block release. > > - Was able to bring up Yunikorn scheduler and admission controller via > helm > > chart. However I couldn't see UI pods. > > - Simple ngnix deployment and sleepbox also went successfully. > > - Killed few pods, and YK was able to bring them up. > > > > Thanks > > Sunil > > > > On Thu, Aug 13, 2020 at 1:34 PM Wilfred Spiegelenburg < > [email protected] > > > > > wrote: > > > > > Hi all > > > > > > > > > This is the second release candidate RC2 for the Apache YuniKorn > > > (incubating) 0.9.0 release. > > > > > > We have resolved 130 issues. Including an extended testing framework, > > > Travis CI, improved auto scaling support and FIFO scheduling. Details > are > > > included in the CHANGELOG as part of the release. > > > > > > > > > The release artifacts are uploaded to: > > > https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.9.0/ > > > > > > My public key is located here: > > > > > > https://dist.apache.org/repos/dist/release/incubator/yunikorn/KEYS > > > > > > > > > The release has been tagged with "v0.9.0" in all our git repositories. > > > > > > > > > The JIRA issues that have been resolved in this release can be found on > > > this link > > > > > > https://issues.apache.org/jira/projects/YUNIKORN/versions/12347799 > > > > > > > > > Please review and vote. The vote will be open for at least 72 hours and > > > closes on *Sunday, 16 August 2020, 17:00 PST*). > > > > > > > > > [ ] +1 approve > > > > > > [ ] +0 no opinion > > > > > > [ ] -1 disapprove (and the reason why) > > > > > > > > > Thank you, > > > > > > Wilfred > > > > > >
