yangwwei commented on a change in pull request #48:
URL:
https://github.com/apache/incubator-yunikorn-release/pull/48#discussion_r733929149
##########
File path: helm-charts/yunikorn/templates/deployment.yaml
##########
@@ -93,6 +93,12 @@ spec:
exec:
command: ["/bin/sh", "/admission_util.sh", "create"]
{{ end }}
+ livenessProbe:
Review comment:
Good point. I think we should have both `failureThreshold` and
`periodSeconds` configurable via helm commands. In order to set this up
differently if needed. E.g from the start point, we might not want to be that
aggressive. But when this is stable enough, we can run this more frequently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
