+1 (binding) Verified the following things:
- Verified the signature - Built from source, docker images are good - Verified the source code SHAs using docker inspect - Successfully installed the build locally using helm-charts - Run a simple job to verify the basic scheduling, verified the events, works fine - Checked the web UI, looks good - Checked the REST APIs, i.e nodes/apps/queues Minor: - I still see an empty dir "charts" under helm-charts dir - I have a problem retrieving key from the MIT key server, this is painful. I tried to import the key locally instead On Tue, Dec 14, 2021 at 8:02 PM Wilfred Spiegelenburg <[email protected]> wrote: > +1 > > Checked the following: > * no unexpected binaries or files > * signature confirmed > * hash confirmed > * build from source > * startup and run the tests > * deployed into kind using helm charts and local build > * checked REST calls: logLevel, healthcheck, and statedump > * checked Web UI > > On Wed, 15 Dec 2021 at 12:41, Chaoran Yu <[email protected]> wrote: > > > Thanks guys for the feedback. Not sure how the public key and files like > > hpa.yaml ended up in the chart. I suspect I did something wrong with SVN. > > The README issue was because a commit that went into master didn’t go > into > > branch-0.12. I’ve fixed that. > > Now reported issues should have been fixed. Since no actual code changes > > occurred, let’s keep voting on the same RC. Please review again. > > > > Thanks, > > Chaoran > > > > > > > > > On Dec 14, 2021, at 16:35, Wilfred Spiegelenburg <[email protected]> > > wrote: > > > > > > -1 based on the helm chart issues: > > > * unknown files in the helm chart (publickey and yaml files) > > > * helm README content is not correct > > > > > > I was able to: > > > * check signature > > > * check hash > > > * build from source > > > * startup and run the tests > > > * manually deployed image > > > > > > On Wed, 15 Dec 2021 at 10:34, Craig Condit <[email protected]> > > wrote: > > > > > >> Seeing a few issues with the archive: > > >> > > >> 1) there’s a stale public.key file in the helm-charts dir, which > should > > >> probably not be in the archive. > > >> 2) The helm charts that are present don’t seem to correspond with any > > >> known version I can see. The differ significantly with both master and > > >> branch-0.12.1 upstream. > > >> 3) helm-charts/yunikorn/README.md seems to be missing the updated K8s > > >> versions (probably a missing commit somewhere). > > >> > > >> > > >> Craig > > >> > > >>> On Dec 14, 2021, at 4:05 PM, Craig Condit <[email protected]> > > >> wrote: > > >>> > > >>> Was able to verify this time. However, I think the archive needs to > be > > >> regenerated as the helm chart key is still the old one (not @ > apache.org > > ). > > >>> > > >>> > > >>>> On Dec 14, 2021, at 3:40 PM, Chaoran Yu <[email protected]> > > >> wrote: > > >>>> > > >>>> Thanks Craig for catching that! I’ve re-signed all the release > > >> artifacts using the key corresponding to my Apache email. New > artifacts > > >> have been uploaded to the same location. My key has been uploaded to > the > > >> MIT key server as well. > > >>>> > > >>>> > > >>>>> On Dec 14, 2021, at 12:45, Craig Condit <[email protected] > > >> <mailto:[email protected]>> wrote: > > >>>>> > > >>>>> Hi Chaoran, > > >>>>> > > >>>>> Thanks for putting all this together. > > >>>>> > > >>>>> I’m trying to verify the release, but am running into some issues > > with > > >> the signing key. Did you upload it to pgpkeys.mit.edu < > > >> http://pgpkeys.mit.edu/><http://pgpkeys.mit.edu/ < > > http://pgpkeys.mit.edu/>>? > > >> Also, it seems that it is not an @apache.org address. AFAIK, that is > > >> required? > > >>>>> > > >>>>> > > >>>>> Thanks, > > >>>>> > > >>>>> Craig > > >>>>> > > >>>>> > > >>>>>> On Dec 14, 2021, at 1:58 PM, Chaoran Yu <[email protected]> > > >> wrote: > > >>>>>> > > >>>>>> My public key is at > > >> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS < > > >> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/KEYS>. > Sorry > > >> about the wrong link > > >>>>>> > > >>>>>> > > >>>>>>> On Dec 14, 2021, at 11:46, Chaoran Yu <[email protected]> > > >> wrote: > > >>>>>>> > > >>>>>>> Hi all, > > >>>>>>> > > >>>>>>> I'd like to call a vote for a release candidate for Apache > YuniKorn > > >> (incubating) 0.12.1 release. > > >>>>>>> > > >>>>>>> The release artifacts have been uploaded to > > >> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.12.1/ < > > >> https://dist.apache.org/repos/dist/dev/incubator/yunikorn/0.12.1/> > > >>>>>>> > > >>>>>>> My public key is located here > > >> https://dist.apache.org/repos/dist/release/incubator/yunikorn/KEYS < > > >> https://dist.apache.org/repos/dist/release/incubator/yunikorn/KEYS> > > >>>>>>> > > >>>>>>> The release has been tagged with "v0.12.1" in all our git > > >> repositories. > > >>>>>>> > > >>>>>>> The JIRA issues that have been resolved in this release can be > > found > > >> here < > > https://issues.apache.org/jira/projects/YUNIKORN/versions/12350843>. > > >>>>>>> > > >>>>>>> Please review and vote. The vote will be open for at least 72 > hours > > >> and > > >>>>>>> closes on Friday, December 17 2021, 1pm PDT. > > >>>>>>> > > >>>>>>> [ ] +1 approve > > >>>>>>> [ ] +0 no opinion > > >>>>>>> [ ] -1 disapprove (and the reason why) > > >>>>>>> > > >>>>>>> > > >>>>>>> Thank you, > > >>>>>>> Chaoran > > >>>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>>> > > >>>> > --------------------------------------------------------------------- > > >>>> To unsubscribe, e-mail: [email protected] > <mailto: > > >> [email protected]> > > >>>> For additional commands, e-mail: [email protected] > > <mailto: > > >> [email protected]> > > >> > > >> > > >> --------------------------------------------------------------------- > > >> To unsubscribe, e-mail: [email protected] > > >> For additional commands, e-mail: [email protected] > > >> > > >> > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > >
