[
https://issues.apache.org/jira/browse/YUNIKORN-1265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wilfred Spiegelenburg resolved YUNIKORN-1265.
---------------------------------------------
Fix Version/s: 1.1.0
Resolution: Fixed
all changes committed, CI integration for the k8shim and core repo
[~lowc1012] thank you for the contribution
> fix shellcheck issues in our shell scripts
> ------------------------------------------
>
> Key: YUNIKORN-1265
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1265
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: build
> Reporter: Wilfred Spiegelenburg
> Assignee: Ryan Lo
> Priority: Major
> Labels: newbie, pull-request-available
> Fix For: 1.1.0
>
> Attachments: yunikorn-1265.patch
>
>
> Throughout our repos we have a number of shell scripts linked to release and
> build mainly.
> These scripts are not checked for issues and or tested. I ran
> [shellcheck|https://github.com/koalaman/shellcheck] over some of them and a
> number of possible issues popped up. We should run the tool over all repos
> and the shell scripts we have and fix the issues found.
> Lots of them are around variable quoting that is missing and the use of
> deprecated back-ticked `cmd` substitution which are not portable. We do not
> have a standard set for these and have mixed them in our use.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
