+1 (binding) - Verified signatures - Verified sha512 sum - Verified the LICENSE changes - Built ARM based image on Mac/amd64 - Ran validation script to verify proper startup - Ran unit tests
Filed YUNIKORN-1305 to fix the sha labeling in the generated image but that is not important enough to stop the release. Wilfred On Fri, 2 Sept 2022 at 03:23, Craig Condit <[email protected]> wrote: > +1. > > - Verified signatures > - Verified sha512 sum > - Built release (on Mac/amd64) > - Ran validation script to verify proper startup > - Executed e2e tests on both standard and plugin mode > > Other than a couple of flaky tests (known issue) everything looks great. > > Thanks Peter for the release work! > > > Craig > > > > > On Sep 1, 2022, at 7:03 AM, Peter Bacsko <[email protected]> wrote: > > > > Thanks Craig. > > > > I re-generated the artifacts with just using "1.1.0" in > > release-configs.json. > > > > It's based the same code base/tags, so it's still the RC1. > > > > I removed the previous artifacts and the new ones are available here: > > https://dist.apache.org/repos/dist/dev/yunikorn/1.1.0-RC1/ > > > > Thanks, > > Peter > > > > On Wed, Aug 31, 2022 at 11:34 PM Wilfred Spiegelenburg < > [email protected]> > > wrote: > > > >> The version that is used in the name is also in the substitutions in the > >> Makefile, helm charts etc. > >> > >> Updating the release-configs.json should be clarified in: > >> * update the version with the release version: examples: 0.12.2 or 1.1.0 > >> * update the tags with the current release tag examples: 0.12.2-1 or > >> 1.0.0-1 > >> > >> We need to re-run the release tool with the update in the version. > >> > >> Wilfred > >> > >> On Thu, 1 Sept 2022 at 00:17, Craig Condit <[email protected]> wrote: > >> > >>> Unfortunately, I have to vote -1 on this. > >>> > >>> Release candidates, if they are to become actual releases, must be > binary > >>> identical once voted upon and released. This archive contains numerous > >>> references to “RC1” including the top-level directory within the > archive > >>> itself. All of these will at a minimum change the sha512sum of the > >> archive, > >>> and logically result in different contents. > >>> > >>> However, I don’t see an issue with the source code, so simply > >> re-releasing > >>> the tarball without ‘-RC1’ in the version will probably work. > >>> > >>> > >>> Craig > >>> > >>> > >>> > >>>> On Aug 31, 2022, at 5:03 AM, Peter Bacsko <[email protected]> wrote: > >>>> > >>>> Hello everyone, > >>>> > >>>> I’d like to call a vote for releasing Apache YuniKorn 1.1.0 RC1. > >>>> > >>>> The release artifacts have been uploaded here: > >>>> https://dist.apache.org/repos/dist/dev/yunikorn/1.1.0-RC1/ > >>>> > >>>> My public key is located here: > >>>> https://downloads.apache.org/yunikorn/KEYS > >>>> > >>>> JIRA issues that have been resolved in this release: > >>>> https://issues.apache.org/jira/issues/?filter=12352202 > >>>> > >>>> Git tags for each component are as follows: > >>>> > >>>> incubator-yunikorn-scheduler-interface: v1.1.0-1 > >>>> incubator-yunikorn-core: v1.1.0-1 > >>>> incubator-yunikorn-k8shim: v1.1.0-1 > >>>> incubator-yunikorn-web: v1.1.0-1 > >>>> incubator-yunikorn-release: v1.1.0-1 > >>>> > >>>> One the release is voted on and approved, all repos will be tagged > >> 1.1.0 > >>>> for consistency. > >>>> > >>>> Please review and vote. The vote will be open for at least 72 hours > and > >>>> closes on Saturday, September 3 2022, 12pm CEST. > >>>> > >>>> [ ] +1 Approve > >>>> [ ] +0 No opinion > >>>> [ ] -1 Disapprove (and the reason why) > >>>> > >>>> > >>>> Thank you, > >>>> Peter > >>> > >>> > >>> --------------------------------------------------------------------- > >>> To unsubscribe, e-mail: [email protected] > >>> For additional commands, e-mail: [email protected] > >>> > >>> > >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
