HuangTing-Yao commented on PR #109:
URL: https://github.com/apache/yunikorn-release/pull/109#issuecomment-1243410087
> I do not think that we should copy this logic. Fixing the calls is a much
better solution. I also noticed that we do not pick up both of the vars in all
cases.
>
> Some investigations show that the difference is behaviour in shell and
make commands. This works on ubuntu and mac for me:
>
> ```
> diff --git a/release-top-level-artifacts/Makefile
b/release-top-level-artifacts/Makefile
> index 177386d..67021e4 100644
> --- a/release-top-level-artifacts/Makefile
> +++ b/release-top-level-artifacts/Makefile
> @@ -51,4 +51,4 @@ test:
>
> .PHONY: arch
> arch:
> - eval `$(MAKE) -C $(SHIM_DIR) arch`
> + @eval "$(MAKE) -C $(SHIM_DIR) arch"
> diff --git a/release-top-level-artifacts/validate_cluster.sh
b/release-top-level-artifacts/validate_cluster.sh
> index 5544df5..087b41e 100755
> --- a/release-top-level-artifacts/validate_cluster.sh
> +++ b/release-top-level-artifacts/validate_cluster.sh
> @@ -80,6 +80,7 @@ function run_detail() {
> echo " Kubernetes image: ${KIND_IMAGE}"
> echo " Registry name: ${REGISTRY}"
> echo " Plugin mode: ${PLUGIN}"
> + echo " Executable Architecture: ${EXEC_ARCH}"
> echo " Image Architecture: ${DOCKER_ARCH}"
> }
>
> @@ -140,7 +141,7 @@ KIND_CONFIG="${KIND_CONFIG:-./kind.yaml}"
> HELMCHART="${HELMCHART:-./helm-charts/yunikorn}"
> PLUGIN="${PLUGIN:-false}"
> # load the docker architecture via make
> -eval "$(make arch)"
> +eval "$(make -s arch)"
>
> # show details for the run
> run_detail
> ```
>
> Can you check if this works on other systems.
It also works on my Ubuntu(both amd64 and arm64).
Agree with @wilfred-s, fixing the make arch call is a better solution.
Thank for your advice, @wilfred-s
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
