[
https://issues.apache.org/jira/browse/YUNIKORN-1529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wilfred Spiegelenburg resolved YUNIKORN-1529.
---------------------------------------------
Fix Version/s: 1.2.0
Resolution: Fixed
Test only change: do not access the placeholderTimer without a lock of the
application.
> Data race in TestTimeoutPlaceholderAllocReleased
> ------------------------------------------------
>
> Key: YUNIKORN-1529
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1529
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: test - unit
> Reporter: Peter Bacsko
> Assignee: Peter Bacsko
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.2.0
>
>
> The following data race was detected during test run:
> {noformat}
> ==================
> WARNING: DATA RACE
> Write at 0x00c00053e898 by goroutine 18:
>
> github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Application).timeoutPlaceholderProcessing()
>
> /home/bacskop/repos/incubator-yunikorn-core/pkg/scheduler/objects/application.go:420
> +0xdbb
>
> github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Application).timeoutPlaceholderProcessing-fm()
> <autogenerated>:1 +0x39
> Previous read at 0x00c00053e898 by goroutine 17:
>
> github.com/apache/yunikorn-core/pkg/scheduler/objects.TestTimeoutPlaceholderAllocReleased()
>
> /home/bacskop/repos/incubator-yunikorn-core/pkg/scheduler/objects/application_test.go:1319
> +0x644
> testing.tRunner()
> /snap/go/9991/src/testing/testing.go:1439 +0x213
> testing.(*T).Run.func1()
> /snap/go/9991/src/testing/testing.go:1486 +0x47
> Goroutine 18 (running) created at:
> time.goFunc()
> /snap/go/9991/src/time/sleep.go:176 +0x47
> Goroutine 17 (running) created at:
> testing.(*T).Run()
> /snap/go/9991/src/testing/testing.go:1486 +0x724
> testing.runTests.func1()
> /snap/go/9991/src/testing/testing.go:1839 +0x99
> testing.tRunner()
> /snap/go/9991/src/testing/testing.go:1439 +0x213
> testing.runTests()
> /snap/go/9991/src/testing/testing.go:1837 +0x7e4
> testing.(*M).Run()
> /snap/go/9991/src/testing/testing.go:1719 +0xa71
> main.main()
> _testmain.go:435 +0x3a9
> ==================
> ==================
> WARNING: DATA RACE
> Write at 0x00c0002fc9c8 by goroutine 18:
>
> github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Application).clearPlaceholderTimer()
>
> /home/bacskop/repos/incubator-yunikorn-core/pkg/scheduler/objects/application.go:359
> +0xfe
>
> github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Application).timeoutPlaceholderProcessing()
>
> /home/bacskop/repos/incubator-yunikorn-core/pkg/scheduler/objects/application.go:423
> +0xe0b
>
> github.com/apache/yunikorn-core/pkg/scheduler/objects.(*Application).timeoutPlaceholderProcessing-fm()
> <autogenerated>:1 +0x39
> Previous read at 0x00c0002fc9c8 by goroutine 17:
>
> github.com/apache/yunikorn-core/pkg/scheduler/objects.TestTimeoutPlaceholderAllocReleased()
>
> /home/bacskop/repos/incubator-yunikorn-core/pkg/scheduler/objects/application_test.go:1323
> +0x85a
> testing.tRunner()
> /snap/go/9991/src/testing/testing.go:1439 +0x213
> testing.(*T).Run.func1()
> /snap/go/9991/src/testing/testing.go:1486 +0x47
> Goroutine 18 (running) created at:
> time.goFunc()
> /snap/go/9991/src/time/sleep.go:176 +0x47
> Goroutine 17 (running) created at:
> testing.(*T).Run()
> /snap/go/9991/src/testing/testing.go:1486 +0x724
> testing.runTests.func1()
> /snap/go/9991/src/testing/testing.go:1839 +0x99
> testing.tRunner()
> /snap/go/9991/src/testing/testing.go:1439 +0x213
> testing.runTests()
> /snap/go/9991/src/testing/testing.go:1837 +0x7e4
> testing.(*M).Run()
> /snap/go/9991/src/testing/testing.go:1719 +0xa71
> main.main()
> _testmain.go:435 +0x3a9
> ==================
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
