[
https://issues.apache.org/jira/browse/YUNIKORN-1853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wilfred Spiegelenburg resolved YUNIKORN-1853.
---------------------------------------------
Fix Version/s: 1.4.0
Resolution: Fixed
Linker sets all details directly in the conf package. Removing duplicated code.
Thank you [~yangpoan] for the fix.
> de-duplicate build info init and storage
> ----------------------------------------
>
> Key: YUNIKORN-1853
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1853
> Project: Apache YuniKorn
> Issue Type: Task
> Components: shim - kubernetes
> Reporter: Wilfred Spiegelenburg
> Assignee: PoAn Yang
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.4.0
>
>
> The build info is set via the linker in the main module on build time. This
> means that each main we have must have the variables defined to set. The main
> function then sets the values in the config to have a centralised place to
> use later.
> We can directly set the values in the config using the linker using the path
> expression supported:
> {{github.com/apache/yunikorn-k8shim/pkg/conf.goVersion}} as an example. It
> also externalises the plugin flag
> Moving it all directly to the config also makes it possible to log all
> details in the same way, i.e. provide a build
> Moving the building of the map and a stringified version of the info into the
> config also removes the need to export all variables in the config.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
