[
https://issues.apache.org/jira/browse/YUNIKORN-1855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Craig Condit resolved YUNIKORN-1855.
------------------------------------
Fix Version/s: 1.4.0
Target Version: 1.4.0
Resolution: Fixed
Merged to master.
> Fix error comment in scheduler_cache_test.go
> --------------------------------------------
>
> Key: YUNIKORN-1855
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1855
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: shim - kubernetes
> Reporter: PoAn Yang
> Assignee: PoAn Yang
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.4.0
>
>
> In the test case {{{}TestAssignedPod{}}}, the comment is "{{{}// the cached
> node has no pods assigned{}}}", but we do "{{{}assert.Equal(t,
> len(cachedNode.Pods), 1){}}}".
>
> In the test case {{{}TestAddPod{}}}, the comment is "{{{}// assumed pod
> should no longer be assumed if node changes{}}}", but we do
> "{{{}assert.Check(t, cache.isAssumedPod(podUID1), "pod is not assumed"){}}}".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
