Filed https://issues.apache.org/jira/browse/YUNIKORN-1866 to address this.

Thanks,
Mani

On Thu, Jul 13, 2023 at 6:51 AM Wilfred Spiegelenburg <[email protected]>
wrote:

> Mani,
>
> There has been no adverse feedback on this email.
> Can you please proceed with logging a jira and cleaning up?
>
> Craig is working on another cleanup in the build via YUNIKORN-1862 [1].
> This change should be added on top of that change to make it easier.
>
> Wilfred
>
> [1] https://issues.apache.org/jira/browse/YUNIKORN-1862
>
> On Tue, 4 Jul 2023 at 16:03, Manikandan R <[email protected]> wrote:
> >
> > Hi,
> >
> > YUNIKORN-448 has introduced the pkg/simulation/gang code directory in
> > k8shim to cover e2e tests for gang scheduling. Off late, it has not been
> > used anywhere else in the source code.
> >
> > In addition, even recent major revamping work 1. Revamp E2E test - Phase
> 1 [
> > https://issues.apache.org/jira/browse/YUNIKORN-1491] 2. Revamp E2E test
> -
> > Phase 2 [https://issues.apache.org/jira/browse/YUNIKORN-1548] did not
> > reference any code in the pkg/simulation/gang code directory. It is not
> > needed and obsolete. Hence, making a proposal to clean up the above
> > mentioned code from k8shim.
> >
> > Please share your thoughts.
> >
> > Thanks,
> > Mani
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [email protected]
> For additional commands, e-mail: [email protected]
>
>

Reply via email to