[
https://issues.apache.org/jira/browse/YUNIKORN-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Craig Condit resolved YUNIKORN-1884.
------------------------------------
Resolution: Fixed
> Fix documentation for allow-preemption flag
> -------------------------------------------
>
> Key: YUNIKORN-1884
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1884
> Project: Apache YuniKorn
> Issue Type: Task
> Components: test - e2e, website
> Reporter: PoAn Yang
> Assignee: PoAn Yang
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.4.0
>
>
> The `yunikorn.apache.org/allow-preemption` is an annotation key, but we put
> it in labels in e2e-test helper function [1]. We need to fix this.
>
> Another question is that we say `allow-preemption` can only be set on the
> PriorityClass in the document [2], but we check the key from Pod annotations
> first and then PriorityClass [3]. Do we want to update the document?
>
> [1]
> [https://github.com/apache/yunikorn-k8shim/blob/ac8df7992c94b9b5c36b28452e2de1b5a050f373/test/e2e/framework/helpers/k8s/pod_conf.go#L91-L100]
> [2]
> [https://yunikorn.apache.org/docs/user_guide/labels_and_annotations_in_yunikorn#annotations-in-yunikorn]
> [3]
> [https://github.com/apache/yunikorn-k8shim/blob/ac8df7992c94b9b5c36b28452e2de1b5a050f373/pkg/cache/task.go#L251-L261]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
