[ 
https://issues.apache.org/jira/browse/YUNIKORN-1951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Craig Condit resolved YUNIKORN-1951.
------------------------------------
     Fix Version/s: 1.4.0
    Target Version: 1.4.0
        Resolution: Fixed

Merged #639 to master.

> Queues with only max resource set shouldn't trigger preemption
> --------------------------------------------------------------
>
>                 Key: YUNIKORN-1951
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1951
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: core - scheduler
>            Reporter: Hsuan Zong Wu
>            Assignee: Craig Condit
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.4.0
>
>
> The function QueuePreemptionSnapshot.IsWithinGuaranteedResource() is used to 
> verify that a queue can trigger preemption by checking that all used 
> resources are within guarantees. Since not all resources may be specified in 
> a guarantee, we (properly) ignore unspecified resources. For example, if only 
> memory is set with a guarantee, then only memory is evaluated to determine if 
> a queue is within guaranteed limits. Things like pods, cpu, ephemeral storage 
> are not evaluated. So far so good.
> However, if no guarantees exist at all (on either the leaf queue or any 
> parent of it), this logic results in the queue being *always* within 
> guaranteed limits. This is incorrect. Instead, the queue should be made 
> ineligible to trigger preemption.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to