Craig Condit created YUNIKORN-2054:
--------------------------------------

             Summary: Shim: Fix dependencies in Makefile
                 Key: YUNIKORN-2054
                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2054
             Project: Apache YuniKorn
          Issue Type: Bug
          Components: shim - kubernetes
            Reporter: Craig Condit


The Makefile dependency lists for generated binary targets is incorrect:
{code:java}
$(DEV_BIN_DIR)/$(SCHEDULER_BINARY): go.mod go.sum pkg
$(DEV_BIN_DIR)/$(PLUGIN_BINARY): go.mod go.sum pkg
$(RELEASE_BIN_DIR)/$(SCHEDULER_BINARY): go.mod go.sum pkg
$(RELEASE_BIN_DIR)/$(PLUGIN_BINARY): go.mod go.sum pkg
$(RELEASE_BIN_DIR)/$(ADMISSION_CONTROLLER_BINARY): go.mod go.sum pkg
$(DEV_BIN_DIR)/$(TEST_SERVER_BINARY): go.mod go.sum pkg
$(RELEASE_BIN_DIR)/$(TEST_SERVER_BINARY): go.mod go.sum pkg{code}
All instances of "pkg" should be changed to "$(shell find pkg)":
{code:java}
...: go.mod go.sum $(shell find pkg){code}
See PR from YUNIKORN-1927 for an example.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to