[ 
https://issues.apache.org/jira/browse/YUNIKORN-1655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wilfred Spiegelenburg resolved YUNIKORN-1655.
---------------------------------------------
    Fix Version/s: 1.4.0
       Resolution: Fixed

thank you for the contribution

delayed commit after approval

> factor out the domain from annotations, use constant
> ----------------------------------------------------
>
>                 Key: YUNIKORN-1655
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-1655
>             Project: Apache YuniKorn
>          Issue Type: Improvement
>          Components: shim - kubernetes
>            Reporter: Wilfred Spiegelenburg
>            Assignee: Guan Wu Su
>            Priority: Minor
>              Labels: newbie, pull-request-available
>             Fix For: 1.4.0
>
>
> {{common/constants/constants.go}} contains al annotations and label 
> definitions.
> Each definition specifies its own domaini part instead of re-using a single 
> defined constant for {{yunikorn.apache.org}} this could easily lead to typos 
> etc in the definitions.
> We should also use a fixed constant for the separator "/" used in all these 
> annotations.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to