[
https://issues.apache.org/jira/browse/YUNIKORN-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Craig Condit resolved YUNIKORN-1952.
------------------------------------
Fix Version/s: 1.4.0
Target Version: 1.4.0
Resolution: Fixed
Merged to master. Thanks [~samhxwu] for the contribution.
> Verify_allow_preemption_tag e2e test doesn't really rely on annotation on
> PriorityClass
> ---------------------------------------------------------------------------------------
>
> Key: YUNIKORN-1952
> URL: https://issues.apache.org/jira/browse/YUNIKORN-1952
> Project: Apache YuniKorn
> Issue Type: Test
> Components: test - e2e
> Reporter: PoAn Yang
> Assignee: Hsuan Zong Wu
> Priority: Minor
> Labels: 1.4.0, pull-request-available
> Fix For: 1.4.0
>
>
> In `InitSleepPod`, it always sets `allow-preemption` annotation to a pod [1].
> In `task.isPreemptSelfAllowed`, it gets `allow-preemption` annotation value
> from the pod first. If it's not found, then it gets the value from
> PriorityClass [2].
> If we want to test `allow-preemption` annotation value on PriorityClass, we
> have to remove the annotation on a pod first, before we create it [3].
> [1]
> [https://github.com/apache/yunikorn-k8shim/blob/8b26c373b4b5ba1c1462cb779a3f467ee0ae6c1d/test/e2e/framework/helpers/k8s/pod_conf.go#L112-L116]
> [2]
> [https://github.com/apache/yunikorn-k8shim/blob/8b26c373b4b5ba1c1462cb779a3f467ee0ae6c1d/pkg/cache/task.go#L251-L261]
> [3]
> [https://github.com/apache/yunikorn-k8shim/blob/8b26c373b4b5ba1c1462cb779a3f467ee0ae6c1d/test/e2e/preemption/preemption_test.go#L510]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
