Vinayak Hegde created YUNIKORN-2153:
---------------------------------------
Summary: Move predicateCheckResult type and tests to their own
files
Key: YUNIKORN-2153
URL: https://issues.apache.org/jira/browse/YUNIKORN-2153
Project: Apache YuniKorn
Issue Type: Improvement
Components: core - scheduler
Reporter: Vinayak Hegde
Assignee: Vinayak Hegde
The predicateCheckResult type should not be part of the preemption.go file.
All declarations and functions that have a predicateCheckResult as receiver or
return value value should be moved. Unused functions should be removed.
Unneeded exports on functions / types should be removed. If exported the
comments on the functions and types need to comply with standard go rules.
All remaining functions should get tests to make sure they are working
correctly.
Additionally, implement Stringer interface so that zap.Any() calls can be
replaced with zap.Stringer() to avoid reflection.
h4.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]