[
https://issues.apache.org/jira/browse/YUNIKORN-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wilfred Spiegelenburg resolved YUNIKORN-2161.
---------------------------------------------
Fix Version/s: 1.5.0
Resolution: Fixed
Cleanup of existing metric code, thx [~brandboat]
> Metrics code cleanup
> --------------------
>
> Key: YUNIKORN-2161
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2161
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - scheduler
> Reporter: Peter Bacsko
> Assignee: Kuan-Po Tseng
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.5.0
>
>
> There are unused methods in the metrics subsystem:
> AddQueuePendingResourceMetrics()
> AddQueuePreemptingResourceMetrics()
> AddQueueAllocatedResourceMetrics()
> (there might be others)
> The production code does not call these methods and there are no unit tests
> either.
> We can also consider removing the interfaces. Right now there is just one
> implementation for everything (CoreQueueMetrics, CoreSchedulerMetrics,
> GoRuntimeMetrics). We don't need to mock metrics because it's very
> lightweight, resetting the state is trivial.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
