Wilfred Spiegelenburg created YUNIKORN-2184:
-----------------------------------------------
Summary: k8shim: fix goconst linter issues
Key: YUNIKORN-2184
URL: https://issues.apache.org/jira/browse/YUNIKORN-2184
Project: Apache YuniKorn
Issue Type: Improvement
Components: shim - kubernetes
Reporter: Wilfred Spiegelenburg
Fix existing goconst linter issues:
{code:java}
pkg/admission/webhook_manager.go:385:21: string `yunikorn` has 3 occurrences,
but such constant `yunikornPod` already exists (goconst)
if !ok || value != "yunikorn" {
^
pkg/cache/context_test.go:245:12: string `app00002` has 3 occurrences, make it
a constant (goconst)
appID2 := "app00002"
^
pkg/cache/application_test.go:166:11: string `app-test-001` has 6 occurrences,
but such constant `appID` already exists (goconst)
appID := "app-test-001"
^
pkg/cache/application_test.go:447:10: string `testUUID001` has 3 occurrences,
make it a constant (goconst)
UUID := "testUUID001"
^
pkg/cache/application.go:104:34: string `no transition` has 3 occurrences, make
it a constant (goconst)
if err != nil && err.Error() != "no transition" {
^
pkg/cache/application_test.go:533:11: string `app00001` has 5 occurrences, but
such constant `appID` already exists (goconst)
appID := "app00001"
^{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
