[ 
https://issues.apache.org/jira/browse/YUNIKORN-2332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Wilfred Spiegelenburg resolved YUNIKORN-2332.
---------------------------------------------
    Fix Version/s: 1.5.0
       Resolution: Duplicate

This issue was introduced in YuniKorn 1.4 via YUNIKORN-2082. That change made 
the application ID reproducible which was needed for the recreate on recovery. 
That did not take into account that a pod UID does not exist in the admission 
controller as per the comments in YUNIKORN-1856 which already fixed the broken 
behaviour introduced by YUNIKORN-1273

> admissionController.filtering.generateUniqueAppId not work as expected
> ----------------------------------------------------------------------
>
>                 Key: YUNIKORN-2332
>                 URL: https://issues.apache.org/jira/browse/YUNIKORN-2332
>             Project: Apache YuniKorn
>          Issue Type: Bug
>          Components: shim - kubernetes
>            Reporter: Kuan-Po Tseng
>            Assignee: Kuan-Po Tseng
>            Priority: Major
>             Fix For: 1.5.0
>
>
> configmap:
> {code}
> apiVersion: v1
> data:
>   admissionController.filtering.generateUniqueAppId: "true"
>   queues.yaml: |
>     partitions:
>       - name: default
>         placementrules:
>           - name: provided
>             create: false
>           - name: tag
>             value: namespace
>             create: true
>         queues:
>           - name: root
>             submitacl: '*'
> kind: ConfigMap
> metadata:
>   creationTimestamp: "2024-01-17T16:22:49Z"
>   name: yunikorn-configs
>   namespace: yunikorn
>   resourceVersion: "20405"
>   uid: 351326f1-760c-4600-906a-1986d91f17c4
> {code}
> sleep.yaml
> {code}
> apiVersion: v1
> kind: Pod
> metadata:
>   labels:
>     app: sleep
>     queue: "root.default"
>   name: task1
> spec:
>   schedulerName: yunikorn
>   restartPolicy: Never
>   containers:
>     - name: sleep-30s
>       image: "alpine:latest"
>       command: ["sleep", "30"]
>       resources:
>         requests:
>           cpu: "100m"
>           memory: "500M"
> {code}
> Execute {code}k create -f sleep.yaml{code} and get an error:
> {code}
> The Pod "task1" is invalid: metadata.labels: Invalid value: "default-": a 
> valid label must be an empty string or consist of alphanumeric characters, 
> '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 
> 'MyValue',  or 'my_value',  or '12345', regex used for validation is 
> '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to