[
https://issues.apache.org/jira/browse/YUNIKORN-2326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved YUNIKORN-2326.
--------------------------------------
Fix Version/s: 1.5.0
Resolution: Fixed
[~priyansh] thanks for nice patch!
> refactor `getAppsByState`, `getRejectedAppsByState`, and
> `getCompletedAppsByState`
> ----------------------------------------------------------------------------------
>
> Key: YUNIKORN-2326
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2326
> Project: Apache YuniKorn
> Issue Type: Improvement
> Reporter: Chia-Ping Tsai
> Assignee: Priyansh Choudhary
> Priority: Minor
> Labels: pull-request-available
> Fix For: 1.5.0
>
>
> `getAppsByState`, `getRejectedAppsByState`, and `getCompletedAppsByState` do
> the similar job that get apps according to specific state. Hence, it would be
> better to have a helper method and then these three methods can reuse the
> code.
>
> [https://github.com/apache/yunikorn-core/blob/master/pkg/scheduler/partition.go#L1075]
> [https://github.com/apache/yunikorn-core/blob/master/pkg/scheduler/partition.go#L1088]
> [https://github.com/apache/yunikorn-core/blob/master/pkg/scheduler/partition.go#L1101]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
