[
https://issues.apache.org/jira/browse/YUNIKORN-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kuan Po Tseng resolved YUNIKORN-2181.
-------------------------------------
Fix Version/s: 1.6.0
Resolution: Resolved
> remove named returns in checkQueueHierarchyForPlacement
> -------------------------------------------------------
>
> Key: YUNIKORN-2181
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2181
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - common
> Reporter: Wilfred Spiegelenburg
> Assignee: SHIAO SZU CHEN
> Priority: Minor
> Labels: newbie, pull-request-available
> Fix For: 1.6.0
>
>
> In the {{pkg/common/configs/configvalidator.go}} the
> {{checkQueueHierarchyForPlacement}} function uses named return values. This
> can easily lead to difficult to diagnose bugs specially with the number of
> naked returns and the length of the function.
> We should remove the named return values and the naked returns.
> Note the linter "nakedret" complains about this when you run a simple
> {{./tools/golangci-lint run}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
