Chia-Ping Tsai created YUNIKORN-2640:
----------------------------------------
Summary: Conside removing config from Clients
Key: YUNIKORN-2640
URL: https://issues.apache.org/jira/browse/YUNIKORN-2640
Project: Apache YuniKorn
Issue Type: Improvement
Reporter: Chia-Ping Tsai
The config (`conf.SchedulerConf`) [0] references to a global singleton object
[1][2]. Also, in the code base `clients#GetConf()` is used 3 times [3] and
`conf.GetSchedulerConf()` is used 61 times [4]
It seems to me `clients#conf` should be removed to avoid confusion.
[0]
https://github.com/apache/yunikorn-k8shim/blob/master/pkg/client/clients.go#L42C8-L42C26
[1]
https://github.com/apache/yunikorn-k8shim/blob/6f2800f689e9e341c736a6af8cbf178a711a9423/pkg/plugin/scheduler_plugin.go#L291
[2]
https://github.com/apache/yunikorn-k8shim/blob/6f2800f689e9e341c736a6af8cbf178a711a9423/pkg/cmd/shim/main.go#L53
[3]
https://github.com/search?q=repo%3Aapache%2Fyunikorn-k8shim+GetConf%28%29&type=code
[4]
https://github.com/search?q=repo%3Aapache%2Fyunikorn-k8shim+conf.GetSchedulerConf%28%29&type=code
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
